feat(backend): add filtering incoming payments by initiatedBy #3714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: tests
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
mkurapov
reviewed
Oct 23, 2025
Comment on lines
630
to
636
| if ( | ||
| [IncomingPaymentState.Pending, IncomingPaymentState.Expired].includes( | ||
| payment.state | ||
| ) | ||
| ) { | ||
| return BigInt(0) | ||
| } |
There was a problem hiding this comment.
We should include the received amount regardless of the incoming payment state
| return payment | ||
| } | ||
|
|
||
| async function getPage( |
There was a problem hiding this comment.
We can have the getWalletAddressPage use this function also, just need to add in the wallet address filter in the options
| "Specify the sort order of incoming payments based on their creation date, either ascending or descending." | ||
| sortOrder: SortOrder | ||
| "Filter incoming payments based on specific criteria such as initiation reason." | ||
| filter: IncomingPaymentFilter |
There was a problem hiding this comment.
Let's add this filter to the walletAddress.incomingPayments resolver (since that is the resolver we will be using for the POS service API)
| function validateReceiveAmount( | ||
| deps: ServiceDependencies, | ||
| payment: IncomingPayment, | ||
| sentAmount: bigint | undefined |
There was a problem hiding this comment.
Suggested change
| sentAmount: bigint | undefined | |
| receivedAmount: bigint | undefined |
oana-lolea
commented
Oct 24, 2025
| const { sortOrder, filter, ...pagination } = args | ||
| const order = sortOrder === 'ASC' ? SortOrder.Asc : SortOrder.Desc | ||
| const incomingPayments = await incomingPaymentService.getWalletAddressPage({ | ||
| const incomingPayments = await incomingPaymentService.getPage({ |
There was a problem hiding this comment.
Used getPage to be able to use the filter
oana-lolea
commented
Oct 24, 2025
| if (walletAddressId) { | ||
| query.where('walletAddressId', walletAddressId) | ||
| } | ||
|
|
There was a problem hiding this comment.
Added client and walletAddressId so that getWalletAddressPage can use getPage
mkurapov
reviewed
Oct 28, 2025
| getPage: (pagination_: Pagination, sortOrder_?: SortOrder) => | ||
| getPageFn(pagination_, sortOrder_), | ||
| page: incomingPayments, | ||
| sortOrder: order |
There was a problem hiding this comment.
We need to add filter in this as well, otherwise the payment results won't match the page info results
mkurapov
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
initiatedByContext
Fixes #3648 | RAF-1165
Checklist
fixes #numberuser-docslabel (if necessary)